Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmail: automatically try to refresh access token when Unauthorized #448

Closed
wants to merge 1 commit into from

Conversation

lostmsu
Copy link

@lostmsu lostmsu commented Oct 21, 2024

somewhat fixes #447 (does not fix the underlying cause when the system believes token is still valid when it's not)

@bkaankose
Copy link
Owner

Thank you for the PR.

The reason I waited to merge this one was due to the work I was doing for Wino Calendar. Authentication library is now abstracted into separate project called Wino.Authentication and all authenticators are moved there.

Previously, authentications were handled by the UWP app, but now since we have a separate server process, it's better to delegate all authentication to the server and completely remove authentication libraries from the UWP app. During this work, I have implemented Gmail Auth library for .NET. Got rid of the old code that UWP was using. This means refreshing token will automatically be handled by this library in the server.

Checking for expired token is also handled in the new authenticator as well using this library. Therefore, these changes makes this PR obsolete for now.

@bkaankose bkaankose closed this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Gmail authentication does not work after a period of being offline
2 participants