Tests: improve CUDA support detection #985
Merged
+26
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implicitly skip any test that implicitly uses CUDA on a non-CUDA box * add a `requires_cuda` fixture
Merged
Titus-von-Koeller
merged commit f1c7574
into
bitsandbytes-foundation:main
1 check passed
|
Looks good to me! Thanks for another useful contribution. Just out of curiosity, of course you don't have to answer, what led you to work with BNB, if you're not running Linux with a GPU? Are you involved with the Apple Silicon cross platform work? |
|
Ah, you said you're on Linux :D |
|
@Titus-von-Koeller Let's just say I have my contributing fingers here and there in the GenAI ecosystem 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the tests require CUDA capabilities; only some of them were previously marked as such and skipped when no CUDA was available, the rest of them were left to fail.
This PR adds a pytest hook that turns the Torch
Torch not compiled with CUDA enabledassertion error intopytest.skip, and a Pytest fixture that a test can use to assert that CUDA support is available too.On a machine where
make cpuonlypasses (namely in alinux/amd64Docker box), running tests onmain(53f8af8) results inWith this PR, the result is a more sensible
(though whether
test_nvidia_transformshould (partially) succeed on a machine with no CUDA is anybody's guess).Related to discussion in #984.