Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation doc page is obsolete #1040

Closed
younesbelkada opened this issue Feb 5, 2024 · 3 comments · Fixed by #1048
Closed

Compilation doc page is obsolete #1040

younesbelkada opened this issue Feb 5, 2024 · 3 comments · Fixed by #1048

Comments

@younesbelkada
Copy link
Collaborator

younesbelkada commented Feb 5, 2024

Currently the compilation guidelines in https://huggingface.co/docs/bitsandbytes/main/en/compiling are obsolete as the makefile has been deleted due to the cmake refactor. It would be great if one could re-write that documentation page so that it is up-to-date with the current way of compiling bnb from source

cc @Titus-von-Koeller

@rickardp
Copy link
Contributor

rickardp commented Feb 6, 2024

Do we need to maintain the install_cuda scripts? It seems they need constant updating with new CUDA versions. Also, the way to specify CUDA version is a lot more standardized with cmake, and we could only refer to this:

https://cliutils.gitlab.io/modern-cmake/chapters/packages/CUDA.html

(Basically, set CMAKE_CUDA_COMPILER to the path to nvcc, version is picked up automagically if I understood the docs correctly)

And then just a link to the CUDA download page:

https://docs.nvidia.com/cuda/cuda-installation-guide-linux/index.html#ubuntu

(Linux users might prefer their distro's method of installing, such as adding the Nvidia apt channels)

Then it's only about, install the CUDA version you want, if you have multiple versions, use -DCMAKE_CUDA_COMPILER=<path to nvcc> -DCUDA_VERSION=<cuda version>. We can probably do away with CUDA_VERSION as it is best left to cmake to figure out

@younesbelkada
Copy link
Collaborator Author

This makes totally sense to me ! Do you want to try your hands on this? Otherwise I can do it and ping you for review

@rickardp
Copy link
Contributor

rickardp commented Feb 6, 2024

I created #1048, please have a look at what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants