Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: normalize tx history #3019

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improve: normalize tx history #3019

wants to merge 5 commits into from

Conversation

gonzaloleon
Copy link
Contributor

@gonzaloleon gonzaloleon commented Dec 4, 2020 •
edited
Loading

Handle multi-recipients transaction with myself address

  • Add misunderstoodOptions param
  • Add tests
  • Add helper

@gonzaloleon gonzaloleon force-pushed the improve/normalizeTxHistory branch from 09305de to 2e2c0c2 Compare December 7, 2020 14:36
@gonzaloleon gonzaloleon force-pushed the improve/normalizeTxHistory branch from 2e2c0c2 to cb277da Compare December 7, 2020 14:40
@gonzaloleon gonzaloleon mentioned this pull request Dec 8, 2020
Merged
@gonzaloleon gonzaloleon changed the title Improvement: normalize tx history Improve: normalize tx history Dec 8, 2020
cmgustavo
cmgustavo approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@cmgustavo cmgustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmgustavo cmgustavo cmgustavo approved these changes

@matiu matiu matiu approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gonzaloleon @matiu @cmgustavo