New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error logger quits on unhandled exception #246

Open

ronyeh3 opened this issue Jul 14, 2020 · 0 comments

ronyeh3 commented Jul 14, 2020 •

edited

Loading

referring https://github.com/bithavoc/express-winston/issues/195

please have a look again
we're just want to expressWinston.errorLogger
to have handleException: true ,
but without process.exit(1)

please see in
\winston\lib\winston\exception-handler.js
line 170

let doExit = typeof this.logger.exitOnError === 'function'
? this.logger.exitOnError(err)
: this.logger.exitOnError;

doExit always have a true value, regardless setting exitOnError:false

should add the exitOnError flag to errorLogger constructor option

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment