Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables missing #226

Open
Howlswolf opened this issue Aug 23, 2023 · 12 comments
Open

Variables missing #226

Howlswolf opened this issue Aug 23, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@Howlswolf
Copy link

Some variables that are usefull are not present in the vmix module and that information is available in the API

Companion 3.1.0+6066-beta-04b04a4b

selectedIndex
for a Powerpoint/Photos/... input type to replace the removed feedback inputSelectedIndexName

solo
for feedback of audio monitoring channel, The feedback for Solo works good, but with the variable you can do expression etc

@Howlswolf Howlswolf added the enhancement New feature or request label Aug 23, 2023
@thedist thedist self-assigned this Sep 2, 2023
@briann5545
Copy link

+100 Missing tons of variables. No way to track active input when it's part of a Multiview/Overlay. All "Feedback" should also be available as Variables to be used in Companion Triggers tab. For example, I can't trigger camera tally lights based on active input if the camera/input is part of a Multiview/Overlay.

@thedist
Copy link
Member

thedist commented Oct 23, 2023

All "Feedback" should also be available as Variables to be used in Companion Triggers tab

No, not everything will be made a variable for performance reasons. There's a reason why config options had to be added to reduce the current set of variables for users struggling with performance on slower systems such as Raspberry Pi's.

If you have 100s of missing variables, list them here and your use case and depending on the need for them there'll be considered for the next update.

@briann5545
Copy link

briann5545 commented Oct 24, 2023 via email

@briann5545
Copy link

briann5545 commented Oct 24, 2023 via email

@briann5545
Copy link

briann5545 commented Oct 25, 2023 via email

@thedist
Copy link
Member

thedist commented Oct 25, 2023

There's no need to cover the same things multiple times. You've mentioned the $(vmix:connected_state) bug, that will be looked at in time, it's a minimal priority, as it's generally considered bad practice to trigger stuff off of connected state as otherwise you'll be triggering things every time there is a minor drop in connection to vMix that may almost instantly get reconnected. Additionally, just because Companion is connected to vMix does not mean it's in a ready state and could still be gathering data from the API/Activators once a connection is established so even if you did try to trigger things when connected there could be data missing and variables not yet filled.

Does anybody test this stuff?

This is free software. You don't pay for the time developers spend working on Companion, or my time developing this module. Testing does take place but there is limited time and resources so I invest my time in more important and critical features first. No one but you has reported this issue until 18 hours ago, so calm down, a fix will be released as and when I get to it.

@briann5545
Copy link

briann5545 commented Oct 25, 2023 via email

@thedist
Copy link
Member

thedist commented Oct 25, 2023

Perhaps go to vMix and take your frustration there then for not being able to support your use case themselves. What you paid for vMix is irrelevant here, as we don't work for vMix or have any association with the vMix developers, all of those who contribute are people who give their free time to work on these modules because we also use vMix.

You also do not see all of the work that is going on behind the scenes in branches not available to you, so please be patient as things are being worked on, and if that is still not acceptable to you then I suggest writing your own vMix integration separate from this module.

@bbbullock
Copy link

I'm coming very late to this discussion re $(vMix:connected_state) not working and have some additional insight to offer. First, I just upgraded to 3.1.1 from a 2.x.x version and the bug appeared then.

When we first starting using Companion close to two years ago, this same bug was in whatever version we were using at the time (v2.x.x) and the author of the Companion vMix module was able to squash the bug with a quick update/patch that they sent to me. A subsequent build of Companion included the fix.

It appears the same bug has now re-appeared and wonder if there's a way to find the update/patch that was applied back then?

I recognize use of this function may not represent best practice, yet it is the only way we can do what $(vMix:connected_state) does for us.

I'm going to try rolling back to v2.4.2 which is available on the Companion site in hopes that the function returns to proper operation.

In the meantime, a huge THANK YOU to the volunteer team that maintains Companion and specifically this vMix module. The time and expertise that is involved is truly appreciated. We really do want to get to v3.1.x when we can!

@bbbullock
Copy link

bbbullock commented Oct 25, 2023

Quick update. I just successfully rolled back to v2.4.2 and $(vMix:connected_state) works as advertised!

One additional note: we've used $(vMix:connected_state) for 2 years and never had a dropped connection. Our use case is to turn on/off some KASA power modules when vMix starts and stops. We also use this to start a vMix script or two when vMix starts.

Hope we can find the v3.1.1. bug and get I squashed!

@bbbullock
Copy link

One additional note. I noticed this is included under "Variables missing" which is tagged as an enhancement. Perhaps we should separate the $(vMix:connected_state) into a separate thread tagged as a bug since that appears to be what it is.

@Howlswolf
Copy link
Author

Ack I hate seeing that this tread got Hijacked by someone who doesn't respect the enormous work that is being done here in this module ... Thanks for all the hard work Jeff, its very appreciated by the majority of the community !

I see that the variable for Solo made its way in the module :) Thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants