Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to drop DESCRIPTION on sync #264

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

ArnyminerZ
Copy link
Member

No description provided.

@ArnyminerZ ArnyminerZ added the enhancement New feature or request label Mar 25, 2024
@ArnyminerZ ArnyminerZ self-assigned this Mar 25, 2024
@ArnyminerZ ArnyminerZ linked an issue Mar 25, 2024 that may be closed by this pull request
Signed-off-by: Arnau Mora Gras <[email protected]>
@ArnyminerZ ArnyminerZ marked this pull request as ready for review March 25, 2024 16:01
@ArnyminerZ ArnyminerZ requested a review from sunkup March 25, 2024 16:01
Copy link
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I just changed the setting explanation.

Original:

If enabled, the DESCRIPTION field will be dropped from each event. This is normally used for adding spammy information to events.

This sounds as if nearly all calendars contain spammy information. :)

So I changed it to:

If enabled, the DESCRIPTION field will be removed from events. Helpful if it contains spammy information.

If you are okay with the change, we can merge 👍

@ArnyminerZ
Copy link
Member Author

Sounds great to me, I'll merge

@ArnyminerZ ArnyminerZ merged commit 79017f8 into dev Mar 27, 2024
7 checks passed
@ArnyminerZ ArnyminerZ deleted the 263-add-option-to-drop-description-on-sync branch March 27, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to drop DESCRIPTION on sync
2 participants