Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use u64 for weights #2

Open
evanlinjin opened this issue Nov 30, 2023 · 1 comment
Open

Use u64 for weights #2

evanlinjin opened this issue Nov 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@evanlinjin
Copy link
Member

This is because rust-bitcoin also uses u64 for weights.

Original comment: bitcoindevkit/bdk#1072 (comment)
@evanlinjin evanlinjin added the enhancement New feature or request label Nov 30, 2023
@LLFourn
Copy link
Collaborator

LLFourn commented Jan 25, 2024

I thought this would be a good idea but I'm now against it as it provides a rudimentary way of stopping you mixing up weights and values. We don't want to wrap these things here like they do in rust-bitcoin (some type aliases would be nice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LLFourn @evanlinjin