Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup create_tx fee_amount usage #1710

Open
notmandatory opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1768
Open

Cleanup create_tx fee_amount usage #1710

notmandatory opened this issue Nov 14, 2024 · 0 comments · May be fixed by #1768
Labels
audit Suggested as result of external code audit module-wallet

Comments

@notmandatory
Copy link
Member

"In create_tx, after fee_amount is used in coin selection it gets assigned new values which end up never being used."
@notmandatory notmandatory added audit Suggested as result of external code audit module-wallet labels Nov 14, 2024
@notmandatory notmandatory added this to BDK Nov 14, 2024
@notmandatory notmandatory moved this to Discussion in BDK Nov 14, 2024
@ValuedMammal ValuedMammal linked a pull request Dec 10, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audit Suggested as result of external code audit module-wallet
Projects
BDK
Status: Discussion
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(wallet): cleanup and remove unused code in create_tx notmandatory/bdk
1 participant
@notmandatory