Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set name of Swift module in uniffi.toml #552

Open
3 tasks
thunderbiscuit opened this issue Jun 5, 2024 · 1 comment
Open
3 tasks

Set name of Swift module in uniffi.toml #552

thunderbiscuit opened this issue Jun 5, 2024 · 1 comment

Comments

@thunderbiscuit
Copy link
Member

thunderbiscuit commented Jun 5, 2024

You can add the module_name field to the uniffi.toml file to name the module correctly from the get go instead of building the default one (bdk.swift) and then renaming it in our shell build file. See all config options for Swift here.

Note that fixing this requires adding to the uniffi.toml file:

[bindings.swift]
cdylib_name = "bdkffi"
module_name = "BitcoinDevKit"

But also fixing the build-local-swift.sh file as well as the CI workflow on the bdk-swift repo.

  • uniffi.toml
  • build-local-swift.sh
  • publish-spm.yaml on bdk-swift repository
@thunderbiscuit
Copy link
Member Author

This might need changes in other places too: we have some files that define metadata for the library that use the bdkFFI string (which then becomes BitcoinDevKitFFI), and the new library headers and umbrella.h and module.modulemap all include it. So not sure if the change in that metadata would have a bigger impact than I initially imaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant