Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W29 BDK Library Team Call #14

Closed
22 tasks done
notmandatory opened this issue Jul 5, 2022 · 6 comments
Closed
22 tasks done

W29 BDK Library Team Call #14

notmandatory opened this issue Jul 5, 2022 · 6 comments
Assignees
Labels
Call Live audio call

Comments

@notmandatory
Copy link
Member

notmandatory commented Jul 5, 2022

W30, BDK Library Dev Call

📆 Tues July 19, 2022 13:00 UTC
📍 Discord General Voice Channel

Discussion Items

  • bdk 0.20.0 Released! 🎉 + examples in tweet thread
  • Draft notes directly in GitHub
  • Any review begs? 🙏
  • Blockers? 🪨

New Projects and Support

  • nourou: "Banxaas : A p2p bitcoin exchange" Sénégal

Top BDK PRs and issues

  • 🎯 BDK Roadmap
  • csralvall: Move change logic to coin_select #630
  • danielabrozzoni: Allow signing only specific leaf hashes #645
  • evanlinjin: Multi descriptor: Decouple transaction building logic #647
  • evanlinjin: Multi descriptor: Introduce DatabaseFactory trait #654
  • csralvall: Consolidate fee_amount and amount_needed #662
  • danielabrozzoni: Various fixes to the fee_amount calculation in create_tx #666
  • vladimirfomene:Add testing on Compact Block filters in CI #668
  • evanlinjin: Introduce get_checksum_bytes method and improvements #671
  • evanlinjin: Fix wallet sync not finding coins of addresses which are not cached #672
  • oleonardolima: feature: add block height checkpoint feature, and add reorganization handling #10

Top BDK_CLI PRs and issues

Top Documentation PRs and issues

  • 🎯 Documentation Roadmap
  • rajarshimaitra: [Refactor] Move tutorials from Blog to Tutorial section #103
  • BitcoinZavior: Add bdk-rn blogpost #107
  • vladimirfomene: Update installation and interface guide of CLI #109

🌅 Future Call Notes

📜 Past Call Notes

@notmandatory notmandatory added the Call Live audio call label Jul 5, 2022
@notmandatory notmandatory self-assigned this Jul 5, 2022
@evanlinjin
Copy link
Member

It will be good to have bitcoindevkit/bdk#671 as these changes will be good for #647 and #654 (in my opinion), but I guess we will find out in the call whether these changes make sense :)

@evanlinjin
Copy link
Member

I also think I just fixed #521 in this PR: bitcoindevkit/bdk#672

May be a good idea to include this in the meeting since I see it is a high-priority bug in the roadmap.

@notmandatory
Copy link
Member Author

Thanks @evanlinjin I added your latest PRs, the last one with the electrum sync might be impacted by the work @LLFourn is doing with bdk_core.

@evanlinjin
Copy link
Member

Thanks @evanlinjin I added your latest PRs, the last one with the electrum sync might be impacted by the work @LLFourn is doing with bdk_core.

Thank you for pointing this out! I had a brief look at the work done on bdk_core, and from my understanding, this bug is not addressed there (and it should have some sort of feedback so that we can implement a similar feedback mechanism around it).

Currently, to sync with bdk_core, you pass a list of scriptPubKeys to the Blockchain client alongside a stop_gap, returning an Update object.

https://github.com/LLFourn/bdk_core_staging/blob/67d1e5499b0eb1de59f652c433c88942646593b3/bdk_esplora/src/ureq.rs#L167

The Update object conveniently contains a last_active_index field. However, it may also be helpful to contain "the last script index looked at". This way, using the stop gap, last active index and last index looked at, we can determine the number of additional scripts to search for in order to satisfy "stop gap".

If I am not wrong, I would assume that this PR should work well with bdk_core (if the suggested feedback is provided). But maybe @LLFourn can provide some more insight.

@evanlinjin
Copy link
Member

I just realized that I maybe should have communicated with the team before trying to tackle the ticket, so I would like to apologize for that and I'll make sure I do so next time.

@danielabrozzoni
Copy link
Member

danielabrozzoni commented Jul 18, 2022

Can we also add #645, #666 and #662?

@notmandatory notmandatory changed the title W30 BDK Library Team Call W29 BDK Library Team Call Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Call Live audio call
Projects
None yet
Development

No branches or pull requests

3 participants