Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRFC not updated #10

Open
calvogenerico opened this issue Jun 14, 2021 · 0 comments
Open

BRFC not updated #10

calvogenerico opened this issue Jun 14, 2021 · 0 comments

Comments

@calvogenerico
Copy link

I'm making a simple lightweight implementation of brfc for javascript/nodejs. For testing purposes I tried to reproduce the brfc of this spec, and I found that the brfc and the version does not match.

The publshed data is:

BRFC title authors version
8eeed98377bd mAPI nChain 1.3.0

But calculating the brfc with this data produces:

const title = 'mAPI'
const author = 'nChain'
const version = '1.3.0'
const result = brfc(title, author, version)
console.log(result) // '625df56f2938'

If I do the same but using 1.2.0 as the version I get the result published in the spec:

const title = 'mAPI'
const author = 'nChain'
const version = '1.2.0'
const result = brfc(title, author, version)
console.log(result) // '8eeed98377bd'

I also saw in the git history that the brfc was not updated in the last version bump. I believe the brfc should match the version data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant