Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement updated Create single-sig wallet flow #404

Closed
stackingsaunter opened this issue May 29, 2024 · 2 comments
Closed

Implement updated Create single-sig wallet flow #404

stackingsaunter opened this issue May 29, 2024 · 2 comments

Comments

@stackingsaunter
Copy link

Here's handoff of Create single-sig wallet flow after round of user testing:

https://www.figma.com/design/CmK2n6zcXUqSTFV8QflP1d/Create-Wallet-Handoff?node-id=0-1&t=nmDB9OCUiurkQ4Jc-0

This assumes that users can’t/shouldn’t use wallet while IBD is in progress (and it’s not assumeUTXO) - If that's wrong the last part still might be updated in the future

@GBKS
Copy link
Contributor

GBKS commented Jun 2, 2024

Awesome. Left a few comments.

Let me know if you disagree, I don't think that dropping a Figma file is sufficient for a hand-off. This one also includes a lot of screens that are not related to creation of a single-sig wallet. Only 6 of the screens are new, and there are minor changes to some of the others. We should split this out as much as we can and update the design docs accordingly. That should also help then with implementation.

The IBD part at the end is not related to the single-sig wallet flow and part of the activity screen milestone and design, so I think we don't need to discuss that here.

Wondering if this is not better posted to the design repo, as this repo is more about implementation...?

@stackingsaunter
Copy link
Author

Closing the issue as it can be followed in design repo:

BitcoinDesign/Bitcoin-Core-App#62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants