Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-resampling xclim indicators wrapped into ensemble processes #256

Open
aulemahal opened this issue Aug 17, 2022 · 1 comment
Open

Non-resampling xclim indicators wrapped into ensemble processes #256

aulemahal opened this issue Aug 17, 2022 · 1 comment

Comments

@aulemahal
Copy link
Collaborator

In the latest finch updates, I forgot to update the "not implemented" indicator list :

not_implemented = [
"DC",
"FWI",
"RH",
"RH_FROMDEWPOINT",
"E_SAT",
"HUSS",
]

I'm not sure what is the purpose of this list, but I can guess it was there to avoid non-resampling indicator to be wrapped into finch?

First question : Why not?
Second question : Taking ensemble statistics on daily variables doesn't make much sense, no? We could add those "converters" to finch, but avoid creating ensemble statistics processes from them?

Currently, the ensemble problem only concerns corn_heat_units, all other non-resampling indicators accept variables that BCCAQv2 doesn't provide. But that's just random luck.

@huard
Copy link
Collaborator

huard commented Aug 17, 2022

These were the processes that required custom input fields, or for some reason didn't automatically work as Processes.

Agree on second question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants