Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark fields depending on source as optional * #50

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Mark fields depending on source as optional * #50

merged 1 commit into from
Dec 4, 2020

Conversation

constantinpape
Copy link
Collaborator

No description provided.

@constantinpape constantinpape mentioned this pull request Nov 26, 2020
Closed
@constantinpape
Copy link
Collaborator Author

As discussed in #48, language and framework should be *optional, because they only need to be included if we have source (which in turn is only required for some of the weight formats).

@constantinpape constantinpape mentioned this pull request Nov 29, 2020
Closed
@FynnBe
Copy link
Member

FynnBe commented Nov 30, 2020

closes #53

@constantinpape
Copy link
Collaborator Author

Pending #54

@constantinpape constantinpape merged commit a6507e6 into master Dec 4, 2020
@constantinpape constantinpape mentioned this pull request Dec 4, 2020
Closed
5 tasks
@oeway oeway deleted the update-source-framework branch June 15, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FynnBe FynnBe FynnBe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@constantinpape @FynnBe