Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose the adapter into multiple cohesive modules housed in different files #23

Open
kpto opened this issue Oct 31, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request refactoring This issue is a refactoring

Comments

@kpto
Copy link
Collaborator

kpto commented Oct 31, 2024

Currently all code is put inside one long file which introduces the following issues:

  1. Visually noisy and distracting
  2. Hard to find the code one wants to work on
  3. Error prone on editing

The long code should be decomposed into multiple cohesive modules housed in different files.

@kpto kpto added the enhancement New feature or request label Oct 31, 2024
@kpto kpto added this to the Version v1 milestone Oct 31, 2024
@kpto kpto self-assigned this Oct 31, 2024
@kpto kpto added this to OTAR3088 Oct 31, 2024
@kpto kpto moved this to In Progress in OTAR3088 Oct 31, 2024
@kpto kpto added the refactoring This issue is a refactoring label Oct 31, 2024
@laulopezreal
Copy link
Contributor

Hi @kpto, I would like to separate the classes from the main adapter's script. Do you think that enters into the scope of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring This issue is a refactoring
Projects
Status: In Progress
Development

No branches or pull requests

2 participants