Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move SequenceVariant.fill_ref() to separate module #593

Open
reece opened this issue Mar 25, 2020 · 4 comments
Open

move SequenceVariant.fill_ref() to separate module #593

reece opened this issue Mar 25, 2020 · 4 comments
Labels
keep alive exempt issue from staleness checks

Comments

@reece
Copy link
Member

reece commented Mar 25, 2020

SequenceVariants have a fill_ref method that requires a data provider instance. This violates the intention to have the classes be data models with intrinsic methods only (i.e., methods that operate only on the data they have). More importantly, it creates circular object dependencies that are, um, awkward.
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Dec 20, 2023
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
@reece reece reopened this Feb 19, 2024
@reece reece added resurrected and removed stale Issue is stale and subject to automatic closing labels Feb 19, 2024
@reece
Copy link
Member Author

reece commented Feb 19, 2024

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a one-time event.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label May 22, 2024
@jsstevenson jsstevenson added keep alive exempt issue from staleness checks and removed stale Issue is stale and subject to automatic closing resurrected labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keep alive exempt issue from staleness checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reece @jsstevenson