Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add support for conventional commits and semantic release #19

Open
reece opened this issue Sep 9, 2023 · 6 comments
Open

RFC: Add support for conventional commits and semantic release #19

reece opened this issue Sep 9, 2023 · 6 comments
Labels
keep alive exempt issue from staleness checks

Comments

@reece
Copy link
Member

reece commented Sep 9, 2023

@reece reece changed the title Add support for conventional commits and semantic release RFC: Add support for conventional commits and semantic release Sep 26, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Oct 27, 2023
Copy link

github-actions bot commented Nov 3, 2023

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
@reece reece reopened this Feb 19, 2024
@reece reece removed the stale Issue is stale and subject to automatic closing label Feb 19, 2024
@reece
Copy link
Member Author

reece commented Feb 19, 2024

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a onos.environ["GITHUB_TOKEN"]e-time event.

@jsstevenson
Copy link
Contributor

@holtgrewe had sketched a release-please based implementation here

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Jun 27, 2024
@jsstevenson jsstevenson added keep alive exempt issue from staleness checks and removed stale Issue is stale and subject to automatic closing labels Jun 27, 2024
@jsstevenson
Copy link
Contributor

One wrinkle: in semantic-release, you designate breaking changes by including BREAKING CHANGE: in the commit body (whereas strictly speaking the conventional commits spec allows either this or a ! in the commit prefix to designate a breaking change). I kind of like this as a practice -- it forces the committer to spell out the breaking change in detail -- but we (Wagner lab) have just been doing the ! prefix, so it'd entail a slight change in workflow. More here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep alive exempt issue from staleness checks
Projects
None yet
Development

No branches or pull requests

3 participants