Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generic parameters for GenStruct and GenEnum #84

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Implement generic parameters for GenStruct and GenEnum #84

merged 4 commits into from
Jun 12, 2024

Conversation

NightEule5
Copy link
Contributor

Fixes #83

VictorKoenders
VictorKoenders reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@VictorKoenders VictorKoenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One naming nitpick, looks good otherwise

src/generate/gen_enum.rs Outdated Show resolved Hide resolved
src/generate/gen_enum.rs Outdated Show resolved Hide resolved
src/generate/gen_struct.rs Outdated Show resolved Hide resolved
src/generate/gen_struct.rs Outdated Show resolved Hide resolved
@VictorKoenders VictorKoenders merged commit f6e5669 into bincode-org:trunk Jun 12, 2024
7 checks passed
@VictorKoenders
Copy link
Contributor

Thanks!

@NightEule5 NightEule5 deleted the features/struct-enum-generics branch June 12, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorKoenders VictorKoenders VictorKoenders left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GenStruct and GenEnum are missing methods to add generic parameters to the struct/enum
2 participants
@NightEule5 @VictorKoenders