Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Bevy 0.12 #24

Closed
bilowik opened this issue Nov 9, 2023 · 3 comments
Closed

Migration to Bevy 0.12 #24

bilowik opened this issue Nov 9, 2023 · 3 comments

Comments

@bilowik
Copy link
Owner

bilowik commented Nov 9, 2023

Currently blocked by an issue with the embedded_asset! macro, see bevyengine/bevy#10377
Could just rework the existing load_internet_asset! macro usage with the changes to UntypedHandle but is probably best to wait on 0.12.1. Alternatively, could probably take a look at the expanded macro and make the necessary adjustments for the pathing and hardcode for now.

@bilowik
Copy link
Owner Author

bilowik commented Nov 9, 2023

I apologize I didn't realize this would show up in that PR.. I thought issue mentions were typically within repository bounds... I didn't mean to gunk up an issue tracker with a silly hobby project. I just wanted to keep tabs on it for when I round back to it in the future.

@bilowik
Copy link
Owner Author

bilowik commented Nov 9, 2023

Decided to look at the expanded macro, was pretty straightforward to make the calls directly and set up the expected path, so went with that. May round back later to rewrite it to utilize the embedded_asset! macro if the fix makes it into 0.12.1.

@bilowik bilowik closed this as completed Nov 9, 2023
@bilowik
Copy link
Owner Author

bilowik commented Nov 9, 2023

Last thing to note, hot reloading will probably not work with the above fix, not that it is needed but if somehow someone happens upon this and tries to make changes and wonders why when they enable the hotreloading feature for embedded assets and it does not work for the shader, this is why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant