Batch lists not sorted

[lemoene]

Keeping long lists in mind, other to the short one we see in relatively empty installations. Like ARs, Batches should by default be listed reverse chronologically new ones at the top.

Older ones are closed and fall off the active lists

Steps to reproduce

Navigate to

https://bikalims.ridingbytes.com/clients/client-1/batches

https://bikalims.ridingbytes.com/batches

Current behavior

Batches appear random order? I think a separate issue to the other sorting issue, seen in the demo on Tuesday but actually been around for long, see https://jira.bikalabs.com/browse/LIMS-2160

I think ALS is in order, else I would've noticed

Expected behavior

By default, Batch lists should be sorted like AR lists, reverse chronologically

[mikejmets]

I found and fixed the issue in the branch https://github.com/mikejmets/bika.lims/tree/BatchesSortOrder but test_LIMS-2076-cancelled-batches-visible-in-lists.py fails and I cannot work out what I did to make it fail.

[mikejmets]

Tried to simulate test_LIMS-2076-cancelled-batches-visible-in-lists.py manually but I can't find a way to create a batch inside a client. No Add button appears on clients/client-1/batches whether I'm logged in as ritamo or labman1. Am I missing something?

[mikejmets]

Changing the sort_on in contentFilter in batchfolder makes the test_LIMS-2076-cancelled-batches-visible-in-lists.py fail in2 places:
line 82: AssertionError: B-001 was cancelled, but does not appear in ROOT cancelled batch listing
line 70: AssertionError: B-002 is active, however it does not appear ROOT default batch listing

How is this possible?

diff --git a/bika/lims/browser/batchfolder.py b/bika/lims/browser/batchfolder.py
index bdce25b..7d0b2f5 100644
--- a/bika/lims/browser/batchfolder.py
+++ b/bika/lims/browser/batchfolder.py
@@ -27,7 +27,7 @@ class BatchFolderContentsView(BikaListingView):
         self.catalog = 'bika_catalog'
         self.contentFilter = {
             'portal_type': 'Batch',
-            'sort_on': 'created',
+            'sort_on': 'BatchDate',
             'sort_order': 'reverse',
             'cancellation_state': 'active'
         }

[ramonski]

I think this PR is also relevant for this issue: #1908