Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morphing deletes element in extremely specific situation involving LastPass extension and no whitespace between elements #60

Open
pedantic-git opened this issue Sep 2, 2024 · 0 comments

Comments

@pedantic-git
Copy link

Hi developers - thanks for such an amazing library!

This has been discussed extensively on the original issue hotwired/turbo#1291 so I'll not repeat it all here.

There is a combination of conditions involving the Lastpass browser extension (which messes with shadow roots) and a form field with no whitespace between the label and the div containing the field that results in the field itself being removed from the DOM by Idiomorph when the page is re-rendered (the input changes significantly in this use case because it is showing an error state).

All thanks to @4lllex for narrowing down the issue and providing reproduction steps in hotwired/turbo#1291 (comment) . I can work around it by adding whitespace in the specific place where it fails, but I think it's still an idiomorph bug so thought I should report it upstream.

Do you need any more information from me to debug this? And thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant