-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #898 #899
Closes #898 #899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work. However, I found some (rather small) issues.
bigbio/hub/hub_repos/sem_eval_2024_task_2/sem_eval_2024_task_2.py
Outdated
Show resolved
Hide resolved
bigbio/hub/hub_repos/sem_eval_2024_task_2/sem_eval_2024_task_2.py
Outdated
Show resolved
Hide resolved
bigbio/hub/hub_repos/sem_eval_2024_task_2/sem_eval_2024_task_2.py
Outdated
Show resolved
Hide resolved
bigbio/hub/hub_repos/sem_eval_2024_task_2/sem_eval_2024_task_2.py
Outdated
Show resolved
Hide resolved
Thanks @mariosaenger for the thorough review! All issues raised by you should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Checkbox
hub/hub_repos/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_BIGBIO_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneBigBioConfig
for the source schema and one for a bigbio schema.datasets.load_dataset
function.python -m tests.test_bigbio_hub <dataset_name> [--data_dir /path/to/local/data] --test_local
.