Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[persistence] change .get and .destroy to take (options, callback) like everything else #59

Open
ahdinosaur opened this issue Jul 2, 2013 · 1 comment
Labels

Comments

@ahdinosaur
Copy link

inconsistency led to changes here: bigcompany/resource@master...bigspace.
imo, consistency will make everything easier, including bigcompany/resource#6.
thoughts?

@Marak
Copy link
Member

Marak commented Jul 3, 2013

Resource.get and Resource.destroy only accept one argument. It doesn't seem right to make them take options hashes.

The fix posted to resource core is wrong. This looks like a side-effect of attempting to merge all forms code into a single file.

The fix is to change the call here: https://github.com/ahdinosaur/bigspace/blob/master/resources/forms/view/form/method.js#L50

I have now added test coverage for resource.invoke : https://github.com/bigcompany/resource/blob/master/test/invoke.js

After adding test coverage I did find an issue with resource.invoke and pushed a small change : bigcompany/resource@b10f2af

@ahdinosaur - If there are still issues with resource.invoke the use-cases can now be added to the invoke test suite as broken tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants