Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resource dependency #4

Open
Marak opened this issue Aug 11, 2015 · 0 comments
Open

Remove resource dependency #4

Marak opened this issue Aug 11, 2015 · 0 comments
Labels
enhancement

Comments

@Marak
Copy link
Member

Marak commented Aug 11, 2015

It's not needed and is generally not a good pattern to force module into being a resource by default.

Modules can be wrapped as resources in projects if the additional functionality is needed.
Marak added a commit that referenced this issue Aug 20, 2015
@Marak
[api] [refactor] Remove resource dep #4
bd551b2 
 * Removes `resource` library
 * Adds `merge-params` as upstream dep
 * Fixes tests
 * Adds stubs for SNI callback
Marak added a commit that referenced this issue Aug 20, 2015
@Marak
[dist] Add back resource #4
bf65176 
 * It's still needed for custom domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Marak