-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choose room layout from plugin #28
Comments
The appliance currently does not support layout changes. However choosing the layout can and should be part of the pairing process. |
I was not aware that the appliance can not currently do this. But do you think it would be possible to add the layout-change capability to the appliance? I do not yet understand why the layout should be chosen during pairing. I would rather argue that the pairing should be quick and easy and you can adjust the default layout (which basically will be defined by the room's hardware admin) later if you want to. But I guess this might depend on the user and this is probably something that warrants some user testing as well. So I will link the two issues and we can start with chosing layout during pairing. |
I agree with you. However when we build this in Berlin, the solution BBB gave us were different join url layout parameters. |
fixes bigbluebutton#26 fixes bigbluebutton#27 fixes bigbluebutton#28
Motivation
A room can have various layouts. A Layout is the mapping of the room's media devices to the BBB UI components, like e.g. "chat on screen X, presentation on screen Y, no participant cameras". These layouts are configured in the room appliance and passed to BBB in an object. We want the user to be able to choose these layouts from a client that has the moderator rights.
Proposed Solution
The plugin should check if the client is moderator. Then it needs to list the layouts that are available for that particular room. This should be found behind the plus-menu button in a similar way to "Manage layouts":
Here we need an additional entry titled "Room Layout" (with some nice icon). After clicking on this a new modal opens that lists the layout available for this room. Since we can not easily provide icons for the rooms, a list that highlights the currently selected layout should be enough:
In this image the "Chat left, video right" is chosen. The list is generated from the
label
key of the layout object (see below for an example).Alternatives Considered
The layout settings should also be choosable from the room appliance. However, the plugin should still be able to control it, to make the control of the room more flexible.
Related Issues
As mentioned by @SamuelWei below, the layout selection can be part of the pairing process. So what is proposed ere should be considered as an additional screen after successful pairing in #26 .
Additional Context
In the html-plugin the layout is currently hard-coded here:
https://github.com/bigbluebutton/bigbluebutton-room-media-connector/blob/main/html-plugin/src/room-media-plugin/component.tsx#L63
An example object the room appliance sends looks currenlty like this:
The text was updated successfully, but these errors were encountered: