Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with responsiveness when saving with default width/height configuration #31

Open
Tracked by #32
chrishbite opened this issue Sep 6, 2024 · 1 comment · May be fixed by #39
Open
Tracked by #32

Issues with responsiveness when saving with default width/height configuration #31

chrishbite opened this issue Sep 6, 2024 · 1 comment · May be fixed by #39
Assignees
Labels
bug Something isn't working

Comments

@chrishbite
Copy link
Collaborator

Expected Behavior

The block should be responsive in both width and height when a user has not specifically chosen to set width and height values.

Actual Behavior

On block addition the containerWidth attribute is being set to a static numeric value and the containerHeight attribute has a default value of 500px, this will lead to the block not scaling correctly when expected to do so as the user did not choose to set specific width and height values in default usage.

Step-by-step reproduction instructions

  1. Add an Image Comparison block
  2. Add both images
  3. Save
  4. Visit frontend
  5. Scale your browsers window down
  6. See that the blocks height is not adjusting and you can no longer see the full image when using the slider

Screenshots, screen recordings, code snippets

N/A

System Information

  • Browser: Firefox Developer Edition 131.0b2 (aarch64)
  • WordPress version: 6.6.1
  • PHP version: 8.2
@chrishbite chrishbite added the bug Something isn't working label Sep 6, 2024
@PaulREnglish PaulREnglish self-assigned this Oct 8, 2024
@PaulREnglish
Copy link

I think the problem will be fixed in #39.

@PaulREnglish PaulREnglish linked a pull request Oct 8, 2024 that will close this issue
6 tasks
@chrishbite chrishbite linked a pull request Oct 31, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants