From 3bfc1d94fb4c2d7877adcc9aafa4a104872937bc Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Wed, 18 Oct 2023 10:54:04 -0400 Subject: [PATCH] Fix years and degrees Units and unit to be singular to match the rest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit What we have ❯ git grep '"Units":' src/appendices/hed.md: "Units": "s", src/appendices/hed.md: "Units": "ms", src/appendices/qmri.md: "Units": "RECOMMENDED", src/appendices/qmri.md:"Units": "second", src/common-principles.md: "Units": "RECOMMENDED", src/common-principles.md: "Units": "kg/m^2", src/modality-agnostic-files.md: "Units": "years" src/modality-specific-files/magnetic-resonance-imaging-data.md: "Units": "rad" src/modality-specific-files/magnetic-resonance-imaging-data.md: "Units": "rad/s", src/modality-specific-files/physiological-and-other-continuous-recordings.md: "Units": "mV" src/modality-specific-files/physiological-and-other-continuous-recordings.md: "Units": "mV" src/modality-specific-files/positron-emission-tomography.md: "Units": "Bq/mL", src/modality-specific-files/positron-emission-tomography.md: "Units": "s" src/modality-specific-files/positron-emission-tomography.md: "Units": "kBq/mL" src/modality-specific-files/positron-emission-tomography.md: "Units": "kBq/mL" src/modality-specific-files/positron-emission-tomography.md: "Units": "arbitrary" src/modality-specific-files/positron-emission-tomography.md: "Units": "arbitrary" src/modality-specific-files/positron-emission-tomography.md: "Units": "arbitrary" which are singular and then in the schema "unit" ❯ git grep -h unit: | sed -e 's,^[- ]*,,g' | sort | uniq -c | sort -n 1 unit: 1 unit: cm 1 unit: degrees 1 unit: g/mL 1 unit: hexadecimal 1 unit: kOhm 1 unit: mL 1 unit: mL/s 1 unit: 'mm^2' 1 unit: mT.s/m 1 unit: ppm 1 unit: rad 1 unit: um 1 unit: uT 1 unit: year 2 unit: cm/s 2 unit: ms 2 unit: mT/m 3 unit: 1/s 3 unit: degree 4 unit: m 6 unit: mm 12 unit: Hz 20 unit: arbitrary 49 unit: s also singular. --- src/modality-agnostic-files.md | 2 +- src/schema/objects/metadata.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modality-agnostic-files.md b/src/modality-agnostic-files.md index 7bc09af991..fb5b04ee3e 100644 --- a/src/modality-agnostic-files.md +++ b/src/modality-agnostic-files.md @@ -269,7 +269,7 @@ to date of birth. { "age": { "Description": "age of the participant", - "Units": "years" + "Units": "year" }, "sex": { "Description": "sex of the participant as reported by the participant", diff --git a/src/schema/objects/metadata.yaml b/src/schema/objects/metadata.yaml index 3e7d3e59a6..d0fa480198 100644 --- a/src/schema/objects/metadata.yaml +++ b/src/schema/objects/metadata.yaml @@ -3263,7 +3263,7 @@ SpoilingRFPhaseIncrement: which is applied to the phase of the excitation pulse at each TR period for achieving RF spoiling. type: number - unit: degrees + unit: degree SpoilingState: name: SpoilingState display_name: Spoiling State