-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance "JSON" documentations with new columns: "requirement level", "data type" #533
Comments
This is somewhat related to #221, which proposes adding a "Type"/"Datatype" field directly to the jsons. I think specifying the required data type in the schema and documentation would eliminate the need for a field specifying type on a file-by-file basis in the jsons, right? EDIT: Also related to #350. |
you mean in the JSON schemas that the bids-validator uses? https://github.com/bids-standard/bids-validator/tree/master/bids-validator/validators/json/schemas and with "specifying in the documentation" I assume that you mean doing what I hint at in the original post of this thread? If I understand you correctly, then yes I would agree that these two aspects are sufficient and we can close #221 |
@sappelhoff Yes, sorry for the poor wording. That's exactly what I mean, although |
Once this PR is done, we can also transfer the benefits over to the validator --> e.g., here: https://github.com/bids-standard/bids-validator/issues/851 |
Whenever we describe JSON files in the BIDS specification, we usually do it using a
FieldName
and aDefinition
column (see e.g., dataset_description.json):In terms of JSON, the
FieldName
is relatively uncontroversial. It must be a key in the JSON file, formatted like this:{ "Authors": }
However, what's happening in
Definition
is a lot more to handle. I suggest to change the way we describe JSON files to the following:I propose this enhancement "as is" ... but for the future, we may also consider turning these tables into YML format, like @tsalo is currently doing with the entity table in #475 (BTW: please review that PR!)
The text was updated successfully, but these errors were encountered: