From 861fb1f7b606bbbe8490b4c51c1b15274c47d139 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Thu, 31 Aug 2023 15:49:19 -0400 Subject: [PATCH 1/3] FIX: Notch frequencies may be specified by three numbers --- src/schema/objects/columns.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/schema/objects/columns.yaml b/src/schema/objects/columns.yaml index 65fbde5a6c..703b7782db 100644 --- a/src/schema/objects/columns.yaml +++ b/src/schema/objects/columns.yaml @@ -302,13 +302,11 @@ notch: display_name: Notch frequencies description: | Frequencies used for the notch filter applied to the channel, in Hz. + If the low and high frequencies are supplied in addition to the center + frequency, it is RECOMMENDED that they take the form `[low, center, high]`, + for example `[60, 120, 180]`. If no notch filter applied, use `n/a`. - anyOf: - - type: number - unit: Hz - - type: string - enum: - - n/a + type: string onset: name: onset display_name: Event onset From 3346056247ecf33e29d68be71eef515b5cac08e5 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Fri, 8 Sep 2023 08:36:31 -0400 Subject: [PATCH 2/3] SCHEMA: Drop from SHOULD to MAY to avoid validation implications --- src/schema/objects/columns.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/schema/objects/columns.yaml b/src/schema/objects/columns.yaml index 703b7782db..923d24aa0c 100644 --- a/src/schema/objects/columns.yaml +++ b/src/schema/objects/columns.yaml @@ -302,9 +302,8 @@ notch: display_name: Notch frequencies description: | Frequencies used for the notch filter applied to the channel, in Hz. - If the low and high frequencies are supplied in addition to the center - frequency, it is RECOMMENDED that they take the form `[low, center, high]`, - for example `[60, 120, 180]`. + If the low and high frequencies are supplied in addition to the center frequency, + they MAY take the form `[low, center, high]`, for example `[60, 120, 180]`. If no notch filter applied, use `n/a`. type: string onset: From 296cebc19efb9fba55b4344df1ed4bda4ee8baa8 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Fri, 8 Sep 2023 08:58:12 -0400 Subject: [PATCH 3/3] FIX: Multiple values are multiple notch frequencies --- src/schema/objects/columns.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/schema/objects/columns.yaml b/src/schema/objects/columns.yaml index 923d24aa0c..90f6c56091 100644 --- a/src/schema/objects/columns.yaml +++ b/src/schema/objects/columns.yaml @@ -302,9 +302,10 @@ notch: display_name: Notch frequencies description: | Frequencies used for the notch filter applied to the channel, in Hz. - If the low and high frequencies are supplied in addition to the center frequency, - they MAY take the form `[low, center, high]`, for example `[60, 120, 180]`. - If no notch filter applied, use `n/a`. + If notch filters are applied at multiple frequencies, + these frequencies MAY be specified as a list, + for example, `[60, 120, 180]`. + If no notch filter was applied, use `n/a`. type: string onset: name: onset