Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MATLAB: set up CI for MacOS and Windows #116

Closed
Remi-Gau opened this issue Jan 20, 2021 · 2 comments
Closed

MATLAB: set up CI for MacOS and Windows #116

Remi-Gau opened this issue Jan 20, 2021 · 2 comments
Labels
infrastructure Anything to do with automation, continuous integration... windows

Comments

@Remi-Gau
Copy link
Collaborator

Yes, I think setting up for at least MacOS will be relatively straight forward: You will just have to make another step like this one:

- name: Install dependencies
run: |
sudo apt-get -y -qq update
sudo apt-get -y install octave liboctave-dev
sudo apt-get -y install nodejs npm

but ensure that the (then two) steps run depending on the OS. that is, one runs only when OS=ubuntu, the other one only when OS=macOs

For the Ubuntu step, you leave everything as it is ... and for the MacOS step you adjust the "apt" installs with "brew" installs. The remaining action should work regardless of ubuntu or MacOS.

--> for windows it would go the same way ... first duplicating the steps, then making them run conditionally on a single OS only, and then adjusting the duplicated-OS-specific steps to actually work on that OS. I mean -> apt on ubuntu, brew on macOS, and maybe chocolatey on windows, ... and so on for all other commands.

I am not sure how easy this will be with windows. I once managed it for a similarly "complicated" install for the bids-validator. Hopefully it can serve as an example of what I mean:

https://github.com/sappelhoff/bids-validator/blob/407b94c388bf36005069e0a4f0c67a21fbcdc8b8/.github/workflows/python_tests.yml#L14-L42

Originally posted by @sappelhoff in #68 (comment)

@Remi-Gau Remi-Gau added the infrastructure Anything to do with automation, continuous integration... label Jan 20, 2021
@Remi-Gau
Copy link
Collaborator Author

See issue #165 as an example of something to check in CI!!

@Remi-Gau Remi-Gau changed the title set up github action for MacOS and Windows MATLAB: set up CI for MacOS and Windows May 1, 2023
@Remi-Gau Remi-Gau moved this to Wish list in BIDS-matlab Jun 17, 2023
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Apr 8, 2024

Won't do unless we start having significant number of bug reports specific to these platforms.

@Remi-Gau Remi-Gau closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@github-project-automation github-project-automation bot moved this from Wish list to Done in BIDS-matlab Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything to do with automation, continuous integration... windows
Projects
Status: Done
Development

No branches or pull requests

1 participant