-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Replace "units" with "unit" in channels.tsv #15
Comments
we also use |
announcement: since there is few more plural columns I generalized this issue into
|
it is also other ❯ git grep units__
src/schema/objects/columns.yaml:units__nirs:
src/schema/objects/columns.yaml:units__motion:
src/schema/rules/tabular_data/motion.yaml: - units__motion
src/schema/rules/tabular_data/motion.yaml: units__motion: required
src/schema/rules/tabular_data/nirs.yaml: - units__nirs
src/schema/rules/tabular_data/nirs.yaml: units__nirs: required not only There is also ❯ git grep xyzt_units
src/schema/meta/context.yaml: xyzt_units:
src/schema/objects/metadata.yaml: for units stored in 'xyzt_units' field) in the NIfTI header.
src/schema/rules/checks/nifti.yaml: - nifti_header.xyzt_units.xyz != 'unknown'
src/schema/rules/checks/nifti.yaml: - nifti_header.dim[0] < 4 || nifti_header.xyzt_units.t != 'unknown' |
but then conundrum is that we do have "Units" as the metadata sidecar field (and additional ones like ❯ grep '^[^ ]*Units': src/schema/objects/metadata.yaml
AnatomicalLandmarkCoordinateUnits:
DigitizedHeadPointsCoordinateUnits:
EEGCoordinateUnits:
FiducialsCoordinateUnits:
HeadCoilCoordinateUnits:
InfusionSpeedUnits:
InjectedMassPerWeightUnits:
InjectedMassUnits:
InjectedRadioactivityUnits:
MEGCoordinateUnits:
MolarActivityUnits:
NIRSCoordinateUnits:
PharmaceuticalDoseUnits:
PixelSizeUnits:
ReconMethodParameterUnits:
SpecificRadioactivityUnits:
TracerMolecularWeightUnits:
Units:
iEEGCoordinateUnits: So we might harmonize for consistency in .tsv header fields but break consistency with "Units" in sidecar... needs thinking! |
All other column names are specified in singular (e.g., type, description, …) and it is not logical to have a unitS column.
Original authors: @sappelhoff
The text was updated successfully, but these errors were encountered: