Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: RRID should be replaced by AltIdentifier #137

Open
cmaumet opened this issue Jul 11, 2024 · 2 comments · May be fixed by #142
Open

[Bug]: RRID should be replaced by AltIdentifier #137

cmaumet opened this issue Jul 11, 2024 · 2 comments · May be fixed by #142

Comments

@cmaumet
Copy link
Collaborator

cmaumet commented Jul 11, 2024

batch name and line

No response

What happened?

As defined in the spec:

AltIdentifier OPTIONAL. URI. For example, the RRID for this software package (cf. scicrunch).
AltIdentifier OPTIONAL. URI. For example, the RRID for this software package (cf. [scicrunch](https://scicrunch.org/resources/about/Getting%20Started)).

Describe the expected ground-truth ?

The expected ground-truth :

What soft is concerned

No response
@cmaumet
Copy link
Collaborator Author

cmaumet commented Jul 11, 2024

As discussed with @bclenet today

@bclenet
Copy link
Collaborator

bclenet commented Jul 11, 2024 •
edited
Loading

For now, all parsers use the bids_prov.utils.get_default_graph function to generate a default graph as starting point.
This function always sets :

"RRID": "RRID:SCR_007037",

which is the RRID for SPM.

@bclenet bclenet linked a pull request Oct 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New @id generation for parsers and other bug corrections bclenet/BEP028_BIDSprov
2 participants
@cmaumet @bclenet