Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column filters apply even if column filters is disabled #37

Open
te-deum opened this issue May 24, 2024 · 1 comment
Open

Column filters apply even if column filters is disabled #37

te-deum opened this issue May 24, 2024 · 1 comment

Comments

@te-deum
Copy link

te-deum commented May 24, 2024

Hi,

When I activate columnFilter, I can filter colmun individually.
But when I deactivate columnFilter then filters applies without any chance to see or access filters value.

Is it possible to change custom-table.vue (around line 403) to add a check if column filters should apply or not.

Before :

if (!props.isServerMode) {
    props.columns?.forEach((d) => {
    ... 
    });

    if (currentSearch.value && rows?.length) {
    ...

After :

if (!props.isServerMode) {
    if (props.columnFilter) {
        props.columns?.forEach((d) => {
        ... 
        });
    }

    if (currentSearch.value && rows?.length) {
    ...
@bhaveshpatel200
Copy link
Owner

Thanks for this.

I will check this and update in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants