Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if more decimals than supported are provided for a token #353

Open
schmanu opened this issue Feb 2, 2022 · 1 comment
Open

Warn if more decimals than supported are provided for a token #353

schmanu opened this issue Feb 2, 2022 · 1 comment

Comments

@schmanu
Copy link
Collaborator

schmanu commented Feb 2, 2022

Currently if we have a Token with i.e. 2 decimals and we provide 4 decimals: 0.1234 we will cut off after the second decimal and ignore the other ones.

This can lead to unexpected behaviour. Currently the UI displays all decimals (in the table for instance) and does not show the cut-off decimals.
I think this should generate a warning in the code editor and display only the decimals which are going to be submitted in the table.
@bh2smith
Copy link
Owner

bh2smith commented Feb 2, 2022

That seems totally reasonable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmanu @bh2smith