why are you limiting the app to specific networks?

[sirpy]

is there a technical reason why it shouldnt run on any deployment of gnosis safe on any network?
why does it have to support only "official" ones?

[bh2smith]

The app technically works on any EVM network that the safe is deployed. However, we do not host the app in the safe App Store. The App Store is hosted in a different repo (I'll try and remember to post the link here shortly) where the supported networks are configured. If there is a network missing that you're interested I. Having, you are more than welcome to include the necessary content here. Minimal info here is a token list (URL) for that network but I believe the application can even run without a provided token list (its just for displaying token icons). Also, it's nice to include a sample file specific to the network (although we haven't yet made this a requirement either). There is an open issue #321 to include sample files for each network.

[bh2smith]

Here is the repo where networks are configured and an example issue to show how new networks are added

safe-global/safe-apps-list#92

[sirpy]

@bh2smith i'm not asking about safe-apps-list
i'm asking why is supported networks hardcoded.. it simply prevents using it on other networks where gnosis-safe is installed without going through a PR here first
for example I wanted to try this app on fuse.io and i'm not able to. obviously i can fork or add it.
i'm just saying that I dont think it should be hardcoded by default

[bh2smith]

Ok so I see that it seems you are referring to this network map

safe-airdrop/src/hooks/token.ts

Lines 13 to 19 in 86de397

	export const networkMap = new Map([
	[1, "mainnet"],
	[4, "rinkeby"],
	[100, "xdai"],
	[137, "polygon"],
	[56, "bsc"],
	]);

Note that we make use of this in a few different places

1. Here in the app interface:

   safe-airdrop/src/App.tsx

   Line 54 in 86de397

   {networkMap.has(safe.chainId) ? (

2. Here when we fetch tokenlist

   safe-airdrop/src/hooks/token.ts

   Lines 29 to 50 in 86de397

   	export const fetchTokenList = async (chainId: number): Promise<TokenMap> => {
   	let tokens: TokenInfo[];
   	switch (chainId) {
   	case 1:
   	const mainnetTokenURL = "https://tokens.coingecko.com/uniswap/all.json";
   	tokens = (await (await fetch(mainnetTokenURL)).json()).tokens;
   	break;
   	case 4:
   	// Hardcoded this because the list provided at
   	// https://github.com/Uniswap/default-token-list/blob/master/src/tokens/rinkeby.json
   	// Doesn't have GNO or OWL and/or many others.
   	tokens = rinkeby;
   	break;
   	case 100:
   	tokens = xdaiTokens.tokens;
   	break;
   	default:
   	console.warn(`Unimplemented token list for ${networkMap.get(chainId)} network`);
   	tokens = [];
   	}
   	return tokenMap(tokens);
   	};

The second point is merely used in a log message so could be removed, but the first (I would have to ask @schmanu if its actually necessary).

We can look into refactoring "hard-coded" network map. We do also hope to introduce sample files for "known" networks.

I guess the only problem is item number 1 above which we can try to remove and then you should be free to run this without any hassle on any network!

[bh2smith]

I have created a PR that should open this up to all networks. Let me know if it works for you.

[sirpy]

cool thanks