Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC++ 2008 SP1 compile error exception_handler.cc(501) : error C2065: 'STATUS_INVALID_PARAMETER' : undeclared identifier #465

Open
GoogleCodeExporter opened this issue Apr 2, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. compile exception_handler with MS VC++ 2008 SP1 (Platform SDK 6.0A)
2.
3.

What is the expected output? What do you see instead?

Expect no build/compile error. But go the following compile error:
4>------ Build started: Project: exception_handler, Configuration: Debug Win32 
------
4>Compiling...
4>exception_handler.cc
4>c:\.work\touchfors_hg\libz\google-breakpad\src\client\windows\handler\exceptio
n_handler.cc(501) : error C2065: 'STATUS_INVALID_PARAMETER' : undeclared 
identifier


What version of the product are you using? On what operating system?

using revision 909 of google-breakpad from svn, Windows 7, MS VisualStudio 2008 
Pro SP1, Platform SDK 6.0A

Please provide any additional information below.

This bug was introduced by revision 897. Version of SDK (6.0A) included in 
VisualStudio 2008 doesn't define such constant. 
I think that compilation with MS Visual studio 2005 also broken. 
I'm attaching simple patch to workaround this issue. 
Installing newer SDK is not an option for me.

Original issue reported on code.google.com by [email protected] on 31 Jan 2012 at 9:58

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 29 Feb 2012 at 11:36

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

The patch looks fine to me, but I'm not able to land it, as I'm not a committer.

Original comment by [email protected] on 1 Mar 2012 at 1:35

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

this patch also looks fine to me too,

Original comment by [email protected] on 4 Jun 2012 at 3:42

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Confirming that this is broken for VS 2005 as well.

Original comment by [email protected] on 5 Apr 2013 at 7:35

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

pelekhay: Please upload the patch to https://breakpad.appspot.com/

Original comment by [email protected] on 5 Apr 2013 at 8:59

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

patch submitted for the review, Issue 555002

Original comment by [email protected] on 10 Apr 2013 at 9:59

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant