You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ensure they're passed to Openskill.ex wherever that's called (3 entries afaik!) and that the results change appropriately
ensure that any current tests of that functionality we have teiserver-side still use the current values and are resilient to changing those config values
The text was updated successfully, but these errors were encountered:
When I was changing tau for the S1 ladder reset, I basically simply hard-coded that in my fork of OpenSkill.ex as quick fix, see https://github.com/StanczakDominik/openskill.ex/blob/163a72f7423b8aa964909ea6aa3e9943739d87a6/lib/openskill/environment.ex#L7 . Ideally these should be passed in as options, and thankfully we actually already have that capability - https://github.com/StanczakDominik/openskill.ex/blob/163a72f7423b8aa964909ea6aa3e9943739d87a6/lib/openskill.ex#L29-L38
This is a simple fix with some interesting aspects so I'll mark it as a good first issue for a new contributor:
#Openskill
subsection doesn't yet exist) and have okay descriptionsOpenskill.ex
wherever that's called (3 entries afaik!) and that the results change appropriatelyThe text was updated successfully, but these errors were encountered: