Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder PickSet::Focus systems #16791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reorder PickSet::Focus systems #16791

wants to merge 1 commit into from
+2 −2

Conversation

UkoeHB
Copy link
Contributor

@UkoeHB UkoeHB commented Dec 12, 2024

Objective

  • PointerInteraction components should be updated before sending picking events. Otherwise they will be stale when event observers run.
  • Allow inserting logic before picking events but after PointerInteraction components have been updated.

Solution

  • Reorder systems in PickSet::Focus.

@UkoeHB UkoeHB added D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Picking Pointing at and selecting objects of all sorts C-Bug An unexpected or incorrect behavior labels Dec 12, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Dec 12, 2024
@NthTensor NthTensor added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriyDev andriyDev andriyDev approved these changes

@NthTensor NthTensor NthTensor approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UkoeHB @alice-i-cecile @NthTensor @andriyDev