-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use one BevyManifest
instance in proc macros
#16766
base: main
Are you sure you want to change the base?
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
b215d32
to
5831a57
Compare
Your PR increases Bevy Minimum Supported Rust Version. Please update the |
…EST_DIR` won't change during the execution.
5831a57
to
2edcc52
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, but as the bot says, you'll need to bump the MSRV. I'm pretty sure that's due to the use of LazyLock here?
No, the MSRV issue was because I also tried to use I did a quick search but did not find any annotations when it was added exactly, so I just reverted back to using As you can see the all the |
I tried to run the ci scripts by Consider adding an advisory for |
The pr says |
Nope, I just forgot to update the label after your response :) This needs a second review then it's good to merge. |
Objective
get_path_direct
since it was only used once anyways and doesn't add much.Solution
Cargo.toml
wont be parsed as often.Testing
Other PR
Similar to #7536 but has no extra dependencies.