-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce support for mixed lighting by allowing lights to opt out of contributing diffuse light to lightmapped objects. #16761
base: main
Are you sure you want to change the base?
Conversation
illuminating lightmapped objects. This should be fully working, but it needs some better documentation and a little polish on the example, so I'm marking it as a draft for now.
The generated |
The generated |
To summarize the discord conversation of what's needed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. I haven't tested anything locally yet, but I'm happy with the implementation.
@JMS55 I made the requested changes. |
This PR adds support for mixed lighting to Bevy, whereby some parts of the scene are lightmapped, while others take part in real-time lighting. (Here real-time lighting means lighting at runtime via the PBR shader, as opposed to precomputed light using lightmaps.) It does so by adding a new field,
affects_lightmapped_meshes
toIrradianceVolume
andAmbientLight
, and a corresponding fieldaffects_lightmapped_mesh_diffuse
toDirectionalLight
,PointLight
,SpotLight
, andEnvironmentMapLight
. By default, this value is set to true; when set to false, the light contributes nothing to the diffuse irradiance component to meshes with lightmaps.Note that specular light is unaffected. This is because the correct way to bake specular lighting is directional lightmaps, which we have no support for yet.
There are two general ways I expect this field to be used:
When diffuse indirect light is baked into lightmaps, irradiance volumes and reflection probes shouldn't contribute any diffuse light to the static geometry that has a lightmap. That's because the baking tool should have already accounted for it, and in a higher-quality fashion, as lightmaps typically offer a higher effective texture resolution than the light probe does.
When direct diffuse light is baked into a lightmap, punctual lights shouldn't contribute any diffuse light to static geometry with a lightmap, to avoid double-counting. It may seem odd to bake direct light into a lightmap, as opposed to indirect light. But there is a use case: in a scene with many lights, avoiding light leaks requires shadow mapping, which quickly becomes prohibitive when many lights are involved. Baking lightmaps allows light leaks to be eliminated on static geometry.
A new example,
mixed_lighting
, has been added. It demonstrates a sofa (model from the glTF Sample Assets) that has been lightmapped offline using Bakery. It has four modes:In baked mode, all objects are locked in place, and all the diffuse direct and indirect light has been calculated ahead of time. Note that the bottom of the sphere has a red tint from the sofa, illustrating that the baking tool captured indirect light for it.
In mixed direct mode, lightmaps capturing diffuse direct and indirect light have been pre-calculated for the static objects, but the dynamic sphere has real-time lighting. Note that, because the diffuse lighting has been entirely pre-calculated for the scenery, the dynamic sphere casts no shadow. In a real app, you would typically use real-time lighting for the most important light so that dynamic objects can shadow the scenery and relegate baked lighting to the less important lights for which shadows aren't as important. Also note that there is no red tint on the sphere, because there is no global illumination applied to it. In an actual game, you could fix this problem by supplementing the lightmapped objects with an irradiance volume.
In mixed indirect mode, all direct light is calculated in real-time, and the static objects have pre-calculated indirect lighting. This corresponds to the mode that most applications are expected to use. Because direct light on the scenery is computed dynamically, shadows are fully supported. As in mixed direct mode, there is no global illumination on the sphere; in a real application, irradiance volumes could be used to supplement the lightmaps.
In real-time mode, no lightmaps are used at all, and all punctual lights are rendered in real-time. No global illumination exists.
In the example, you can click around to move the sphere, unless you're in baked mode, in which case the sphere must be locked in place to be lit correctly.
Showcase
Baked mode:
Mixed direct mode:
Mixed indirect mode (default):
Real-time mode:
Migration guide
AmbientLight
resource, theIrradianceVolume
component, and theEnvironmentMapLight
component now haveaffects_lightmapped_meshes
fields. If you don't need to use that field (for example, if you aren't using lightmaps), you can safely set the field to true.DirectionalLight
,PointLight
, andSpotLight
now haveaffects_lightmapped_mesh_diffuse
fields. If you don't need to use that field (for example, if you aren't using lightmaps), you can safely set the field to true.