bevy_input_focus improvements (follow-up PR) #16665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initialize InputFocusVisible resource. - Make `input_focus` available from `bevy` module.
crates/bevy_input_focus/src/lib.rs
Outdated
| @@ -135,6 +138,13 @@ fn dispatch_keyboard_input( | |||
| } | |||
| } | |||
|
|
|||
| /// System which synchronizes the a11y focus state with the input focus state. | |||
| fn sync_a11y_focus(focus: Res<InputFocus>, mut a11y_focus: ResMut<Focus>) { | |||
There was a problem hiding this comment.
This seems silly: shouldn't we just change the a11y focus to use the new resource?
There was a problem hiding this comment.
Uh, I did it this way because my understanding was (based on our previous discussion) that we couldn't have bevy_a11y depend on bevy_input_focus.
There was a problem hiding this comment.
Hmm. Maybe I'm misremembering or maybe there was a micommunication, but bevy_a11y depending on bevy_input_focus definitely seems more correct than the reverse (like it is now).
alice-i-cecile
requested changes
Dec 6, 2024
alice-i-cecile
approved these changes
Dec 6, 2024
alice-i-cecile
added
C-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few minor items which were left out of the previous PR:
input_focusavailable frombevymodule.I've tested this using VoiceOver on Mac OS. It works, but it needs considerable polish.