Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative font_size warning #9655

Open
ickshonpe opened this issue Aug 31, 2023 · 2 comments · May be fixed by #9660
Open

Negative font_size warning #9655

ickshonpe opened this issue Aug 31, 2023 · 2 comments · May be fixed by #9660
Labels
A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@ickshonpe
Copy link
Contributor

ickshonpe commented Aug 31, 2023 •
edited
Loading

What problem does this solve or what need does it fill?

At the moment if text is spawned with a negative font_size value, it fails silently and nothing is displayed.

What solution would you like?

I think we should emit a warning at least.
@ickshonpe ickshonpe added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 31, 2023
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 31, 2023
@hate hate linked a pull request Aug 31, 2023 that will close this issue
Open
@KingTheSim
Copy link

Hello. May I try to do this issue as my first contribution?

@mockersf
Copy link
Member

mockersf commented Sep 1, 2023

@KingTheSim #9660 has been opened not so long ago, you can help by reviewing it 🙂

@rparrett rparrett added the A-Text Rendering and layout for characters label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add font size warning to TextSection SuchAndThings/bevy
5 participants
@rparrett @alice-i-cecile @mockersf @ickshonpe @KingTheSim