Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks and compile fail tests back to workspace #16801

Open
BD103 opened this issue Dec 13, 2024 · 0 comments
Open

Add benchmarks and compile fail tests back to workspace #16801

BD103 opened this issue Dec 13, 2024 · 0 comments
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change C-Tracking-Issue An issue that collects information about a broad development initiative D-Straightforward Simple bug fixes and API improvements, docs, test and examples

Comments

@BD103
Copy link
Member

BD103 commented Dec 13, 2024

The benchmarks and compile_fail UI tests are currently excluded from the main Cargo workspace:

bevy/Cargo.toml

Lines 16 to 22 in 00722b8

exclude = [
"benches",
"crates/bevy_derive/compile_fail",
"crates/bevy_ecs/compile_fail",
"crates/bevy_reflect/compile_fail",
"tools/compile_fail_utils",
]

This is a problem because these things get checked less often, and often lag behind. For example, in #16733 I had to fix a compile error for a function that was removed in 0.10 (we just released 0.15). The best solution to prevent this from happening in the future is to re-add the benchmarks and UI tests to the main Cargo workspace.

Past attempt: #16770

@BD103 BD103 added C-Code-Quality A section of code that is hard to understand or change C-Tracking-Issue An issue that collects information about a broad development initiative A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Dec 13, 2024
@BD103 BD103 added A-Build-System Related to build systems or continuous integration and removed A-Cross-Cutting Impacts the entire engine labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change C-Tracking-Issue An issue that collects information about a broad development initiative D-Straightforward Simple bug fixes and API improvements, docs, test and examples
Projects
None yet
Development

No branches or pull requests

1 participant