-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert gizmo configuration #11569
Comments
Jondolf
added
C-Feature
A new feature, making something new possible
A-Gizmos
Visual editor and debug gizmos
labels
Jan 27, 2024
About this, this error doesn't seen to happen after #11420, or is there another error in this fields? 🤔 |
Ah, I didn't actually try if it errors there, I just assumed that it wouldn't add the group if done before the |
I like the naming, and think this should exist. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 28, 2024
# Objective - Fixes #11569 ## Solution - Add new methods to the Ext Trait --- ## Changelog ### Added - Added new methods to the trait `AppGizmoBuilder` --------- Co-authored-by: Alice Cecile <[email protected]>
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this issue
Feb 6, 2024
# Objective - Fixes bevyengine#11569 ## Solution - Add new methods to the Ext Trait --- ## Changelog ### Added - Added new methods to the trait `AppGizmoBuilder` --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this solve or what need does it fill?
With Bevy's new support for multiple gizmo configurations (#10342), it's possible to initialize configurations using
init_gizmo_group
. However, there doesn't seem to be an API to initialize it with a specific value.The only way that I found outside of scheduling a startup system (which I can't do in my case) is to do this:
which is not ideal. I think it also has issues if the plugin is added before the
GizmoPlugin
.My use case is that bevy_xpbd has a
PhysicsDebugConfig
resource and aPhysicsDebugRenderer
system parameter that renders colliders, joints, contacts, and so on. With the new gizmo API, I'm combining these into a singlePhysicsGizmos
gizmo config group that stores the config that was previously stored inPhysicsDebugConfig
and has some methods for e.g. rendering colliders.I need to (1) configure some properties of the
GizmoConfig
to non-default values, and (2) give people an easy API to configurePhysicsGizmos
for e.g. disabling collider rendering. This should be doable during initialization, not just in a system. I can not make aStartup
system for it as it could conflict with users' systems that useGizmoConfigStore
in that schedule.What solution would you like?
Add an
insert_gizmo_group
method toApp
:There must also be a way to set the
GizmoConfig
associated with the gizmo group. This could be aninsert_gizmo_config
orconfigure_gizmo_config
method:The text was updated successfully, but these errors were encountered: