From 5d3f66fbaf53c708a779660c69966a7a4b78cc3a Mon Sep 17 00:00:00 2001 From: Ame <104745335+ameknite@users.noreply.github.com> Date: Thu, 22 Feb 2024 12:13:45 -0600 Subject: [PATCH] Fix taplo CI - toml fmt (#12037) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Objective - Taplo in CI is not running. The link used to download taplo doesn't work anymore. ## Solution - Compile taplo directly with cargo - Improve docs a little - Run taplo --------- Co-authored-by: François --- .github/workflows/ci.yml | 11 ++++++----- crates/bevy_transform/Cargo.toml | 4 +++- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ed2b3961782c8..54adacae3238b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -168,11 +168,9 @@ jobs: timeout-minutes: 30 steps: - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@stable - name: Install taplo - run: | - curl -fsSL https://github.com/tamasfe/taplo/releases/latest/download/taplo-full-linux-x86_64.gz \ - | gzip -d - \ - | install -m 755 /dev/stdin /usr/local/bin/taplo + run: cargo install taplo-cli --locked - name: Run Taplo id: taplo run: taplo fmt --check --diff @@ -180,7 +178,10 @@ jobs: if: failure() run: | echo 'To fix toml fmt, please run `taplo fmt`' - echo 'Or if you use VSCode, use the Even Better Toml extension' + echo 'To check for a diff, run `taplo fmt --check --diff' + echo 'You can find taplo here: https://taplo.tamasfe.dev/' + echo 'Or if you use VSCode, use the `Even Better Toml` extension with 2 spaces' + echo 'You can find the extension here: https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml' run-examples-on-windows-dx12: diff --git a/crates/bevy_transform/Cargo.toml b/crates/bevy_transform/Cargo.toml index 7634217179e2c..c899e8842f95b 100644 --- a/crates/bevy_transform/Cargo.toml +++ b/crates/bevy_transform/Cargo.toml @@ -24,7 +24,9 @@ thiserror = "1.0" [dev-dependencies] bevy_tasks = { path = "../bevy_tasks", version = "0.14.0-dev" } -bevy_math = { path = "../bevy_math", version = "0.14.0-dev", features = ["approx"] } +bevy_math = { path = "../bevy_math", version = "0.14.0-dev", features = [ + "approx", +] } approx = "0.5.1" [features]