4674 refacto classes etl #4675
Merged
4674 refacto classes etl #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 tasks
…entation de la classe Cantee
qloridant
force-pushed
the
4674-refacto-classes-etl
branch
from
42a9eba
to
86f3f38
Compare
…facto-classes-etl
hfroot
approved these changes
Nov 25, 2024
macantine/etl/etl.py
Outdated
| logger.error(report["tasks"]) | ||
| return 0 | ||
| else: | ||
| return 1 |
There was a problem hiding this comment.
ce serait plus lisible de faire return False et return True
There was a problem hiding this comment.
Refacto faite : 7e53e77
raphodn
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.