From 06963541c17544a1ea7fff5f9bcb744c078f650d Mon Sep 17 00:00:00 2001
From: Mark Haslinghuis <mark@numloq.nl>
Date: Fri, 4 Oct 2024 18:16:41 +0200
Subject: [PATCH] Fix sonar

---
 src/js/tabs/motors.js | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/js/tabs/motors.js b/src/js/tabs/motors.js
index b729fd85e99..010b374fbe2 100644
--- a/src/js/tabs/motors.js
+++ b/src/js/tabs/motors.js
@@ -755,13 +755,15 @@ motors.initialize = async function (callback) {
                 default:
             }
 
+            const analogProtocolConfigured = protocolConfigured && !digitalProtocol;
+            const digitalProtocolConfigured = protocolConfigured && digitalProtocol;
             const rpmFeaturesVisible = digitalProtocol && dshotBidirElement.is(':checked') || $("input[name='ESC_SENSOR']").is(':checked');
 
-            $('div.minthrottle').toggle(protocolConfigured && !digitalProtocol && semver.lt(FC.CONFIG.apiVersion, API_VERSION_1_47));
-            $('div.maxthrottle').toggle(protocolConfigured && !digitalProtocol);
-            $('div.mincommand').toggle(protocolConfigured && !digitalProtocol);
-            $('div.checkboxPwm').toggle(protocolConfigured && !digitalProtocol);
-            divUnsyncedPWMFreq.toggle(protocolConfigured && !digitalProtocol);
+            $('div.minthrottle').toggle(analogProtocolConfigured && semver.lt(FC.CONFIG.apiVersion, API_VERSION_1_47));
+            $('div.maxthrottle').toggle(analogProtocolConfigured);
+            $('div.mincommand').toggle(analogProtocolConfigured);
+            $('div.checkboxPwm').toggle(analogProtocolConfigured);
+            divUnsyncedPWMFreq.toggle(analogProtocolConfigured);
 
             $('div.digitalIdlePercent').toggle(protocolConfigured && (digitalProtocol || semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_47)));
             $('div.idleMinRpm').toggle(protocolConfigured && digitalProtocol && FC.MOTOR_CONFIG.use_dshot_telemetry);
@@ -770,9 +772,9 @@ motors.initialize = async function (callback) {
                 $('div.digitalIdlePercent').hide();
             }
 
-            $('.escSensor').toggle(protocolConfigured && digitalProtocol);
+            $('.escSensor').toggle(digitalProtocolConfigured);
 
-            $('div.checkboxDshotBidir').toggle(protocolConfigured && digitalProtocol);
+            $('div.checkboxDshotBidir').toggle(digitalProtocolConfigured);
             $('div.motorPoles').toggle(protocolConfigured && rpmFeaturesVisible);
 
             $('.escMotorStop').toggle(protocolConfigured);