You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mostly a style thing, but I think the case statements in the Protocol could be more beneficial than the case statements. It keeps indentation down.
The main reason that I am bring this up is that none of the :gen_tcp.recv function calls deal with errors being returned. If you refactored the case statements into function calls, you could easily field the :gen_tcp:recv errors in a single function call, instead of dealing with the errors in each case statement.
The text was updated successfully, but these errors were encountered:
Mostly a style thing, but I think the case statements in the Protocol could be more beneficial than the case statements. It keeps indentation down.
The main reason that I am bring this up is that none of the
:gen_tcp.recv
function calls deal with errors being returned. If you refactored the case statements into function calls, you could easily field the:gen_tcp:recv
errors in a single function call, instead of dealing with the errors in each case statement.The text was updated successfully, but these errors were encountered: