Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor setting has no effect? #259

Open
armin-reichert opened this issue Feb 14, 2024 · 7 comments
Open

Vendor setting has no effect? #259

armin-reichert opened this issue Feb 14, 2024 · 7 comments

Comments

@armin-reichert
Copy link

In my build.gradle, I set the vendor property, however in the generated installer I do not see it anywhere. Is this a bug?

@airsquared
Copy link
Collaborator

I believe the vendor is only set in the application, not in the installer. The jpackage documentation isn't very clear on this though.

@armin-reichert
Copy link
Author

Thanks for answering. But which effect then has specifying vendor = "XYZ" inside the jpackage { } section?

@airsquared
Copy link
Collaborator

I apologize, the vendor is actually only set in the installer and not in the application.

You can verify that it is being set by appending the argument --info to your gradle command and checking the shell output of the task jpackage. There will be a log entry that shows the command being sent to jpackage. If the vendor is being set in the jpackage command, then it would be an error with jpackage and not this plugin.

@armin-reichert
Copy link
Author

armin-reichert commented May 24, 2024

I found out where to set these jpackage parameters:

jpackage {
      appVersion = '1.0'
      description = 'Pac-Man JavaFX (3D version)'
      vendor = 'Armin Reichert'
     ...
}

But only the `appVersion``` parameter seems to have any effect (appears as suffix of the exe-file and in the application installer entry in the Windows apps list)

@vewert
Copy link

vewert commented May 25, 2024

I create an .msi installer, so it may be different, but I set the vendor as an installerOption, e.g.

jpackage {
    skipInstaller = false
    installerType = "msi"
    imageOptions = listOf(
        "--app-version", "1.0.0",
    )
    installerName = msiInstallerBaseName
    installerOptions = listOf(
        "--vendor", "Ewert Technologies",
        "--win-dir-chooser",
        "--win-menu",
        "--win-shortcut",
        "--win-shortcut-prompt",
        other installer options...
    )
}

Then, in the installer .msi file's properties, I see Ewert Technologies, listed as Authors, in the details tab.

I also see Ewert Technologies listed in the Windows app list.

@armin-reichert
Copy link
Author

It seems that the vendor can be set in both ways as shown above. But I dont't see the vendor in the Windows app list (Windows 10 Pro, 22H2).

While we are at it: Do you know what has to be done such that the Windows installer knows the publisher and the security popup doesn't show "Publisher: Unknown"?

@vewert
Copy link

vewert commented May 30, 2024

I've seen that vendor problem for Windows 10 before. It does, however, seem to work on Windows 11.

I'm not totally sure, but I think the "Verified Publisher" that is displayed in the Security prompt comes from the signing certificate that was used to sign the .msi installer. At least that is what looks to be happening in my case. Are you signing your installer file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants